Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5848)

Unified Diff: Source/web/tests/WebDocumentTest.cpp

Issue 476553002: Navigation transitions: Hide transition elements by setting CSS opacity rather than display. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Test fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/testing/Internals.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebDocumentTest.cpp
diff --git a/Source/web/tests/WebDocumentTest.cpp b/Source/web/tests/WebDocumentTest.cpp
index 923e23d444c9dc8bde4f56677d82097e6c4ac023..186ab316cbc48bc74d80e735f59fdae7506bd68e 100644
--- a/Source/web/tests/WebDocumentTest.cpp
+++ b/Source/web/tests/WebDocumentTest.cpp
@@ -98,7 +98,8 @@ TEST(WebDocumentTest, BeginExitTransition)
// The element should now be hidden.
transitionStyle = transitionElement->renderStyle();
- ASSERT_FALSE(transitionStyle);
+ ASSERT_TRUE(transitionStyle);
+ ASSERT_EQ(transitionStyle->opacity(), 0);
// The stylesheet should now have been applied.
bodyStyle = bodyElement->renderStyle();
« no previous file with comments | « Source/core/testing/Internals.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698