Navigation transitions: Hide transition elements by setting CSS opacity rather than display.

Source/core/dom/Document.cpp

Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index ad901ee9f0a31e05ae7cdc8c6c3551b5b8e5ab1d..16f72ada230b29e2404ca559e99fbac67567b8bf 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -5641,7 +5641,7 @@ void Document::hideTransitionElements(const AtomicString& cssSelector)
 
         for (unsigned nodeIndex = 0; nodeIndex < nodeListLength; ++nodeIndex) {
             Element* element = elementList->item(nodeIndex);
-            element->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone);
+            element->setInlineStyleProperty(CSSPropertyVisibility, CSSValueHidden);

[abarth-chromium, 2014/08/14 22:22:04]

What if a descendant has visibility: visible set explicitly?

[oystein (OOO til 10th of July), 2014/08/14 22:33:14]

Hm yeah I see what you mean. What do you suggest doing in this case? 

I could see either
1) Leaving it as it is and interpreting that explicit value as meaning the
content creator doesn't want the element hidden when the transition is happening
(i.e. get duplicated rather than "moved"), or
2) Recurse and set visibility: hidden on all children.
3) ?

         }
     }
 }