Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 476543002: content: Remove deprecated functions from blink_test_environment.* (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin (slow to review), jam, abarth-chromium
Project:
chromium
Visibility:
Public.

Description

content: Remove deprecated functions from blink_test_environment.* After deleting webkit_support.h and updating Blink at https://src.chromium.org/viewvc/blink?revision=179977&view=revision, these functions aren't needed anymore and thus can be removed now. BUG=None TEST=webkit_unit_tests R=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M content/test/blink_test_environment.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/test/blink_test_environment.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
Forgot to do this when I deleted webkit_support.h.
6 years, 4 months ago (2014-08-14 01:29:03 UTC) #1
Avi (use Gerrit)
lgtm yep!
6 years, 4 months ago (2014-08-14 14:46:54 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-14 23:48:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/476543002/1
6 years, 4 months ago (2014-08-14 23:51:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 05:56:41 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 15:11:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 289859

Powered by Google App Engine
This is Rietveld 408576698