Re-land r289084 - "Make telemetry*_unittests upload to test-results.appspot.com"

Re-land r289084 - "Make telemetry*_unittests upload to test-results.appspot.com"

This version differs from the prior attempt by

a) changing the logic so that we only upload the results if we're not running on a trysever.

b) retrieving the repo revisions from the data that bot_update got, rather than whatever was passed in as part of build_properties. Turns out that the build_properties would've only had 'parent_got_revision' set and not 'got_revision', so we were likely referencing keys that didn't exist.

As part of (b), this changes adds a "properties" property to the bot_update recipe module so that we can retrieve what bot_update actually did.

R=agable@chromium.org
BUG=323212, 403564
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=289434

[Dirk Pranke, 2014-08-13 23:43:50]

https://codereview.chromium.org/476503002/diff/1/scripts/slave/recipe_modules...
File scripts/slave/recipe_modules/chromium/api.py (right):

https://codereview.chromium.org/476503002/diff/1/scripts/slave/recipe_modules...
scripts/slave/recipe_modules/chromium/api.py:339: 'chromium_revision=%s' %
self.m.properties['got_revision'],
per iannucci@, we probably can't depend on 'got_revision' always being set
(e.g., on a tester slave).

Is the best thing to do to check for 'got_revision' or 'parent_got_revision', or
something else?

[Dirk Pranke, 2014-08-14 00:25:38]

Updated. 

This version has the nice property that we didn't change anything in the
*expected* files that we wouldn't expect to change!

[agable, 2014-08-14 00:34:14]

https://codereview.chromium.org/476503002/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/bot_update/api.py (right):

https://codereview.chromium.org/476503002/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/bot_update/api.py:174: if 'properties' in
step_result.json.output:
If you default self._properties to {} instead of None, you could remove this
conditional. Otherwise, I'd at least make it "if self.properties:"...

[Dirk Pranke, 2014-08-14 00:39:46]

https://codereview.chromium.org/476503002/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/bot_update/api.py (right):

https://codereview.chromium.org/476503002/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/bot_update/api.py:174: if 'properties' in
step_result.json.output:
On 2014/08/14 00:34:14, agable wrote:
> If you default self._properties to {} instead of None, you could remove this
> conditional. Otherwise, I'd at least make it "if self.properties:"...

Good suggestion. Updated.

[agable, 2014-08-14 00:41:10]

LGTM, I like it.

[Dirk Pranke, 2014-08-14 00:42:37]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2014-08-14 00:55:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dpranke@chromium.org/476503002/40001

[commit-bot: I haz the power, 2014-08-14 01:01:01]

Committed patchset #3 (40001) as 289434

[Paweł Hajdan Jr., 2014-08-14 08:21:20]

A revert of this CL (patchset #3) has been created in
https://codereview.chromium.org/475683003/ by phajdan.jr@chromium.org.

The reason for reverting is: Reverting telemetry-related changes because of
breakages like
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%282%29/buil...
. Please watch the waterfall after applying the change..