Add measure_trace tool allows us to measure smoothness given a timeline trace

Add measure_trace tool allows us to measure smoothness given a timeline trace
marked with timeline interaction records.

The result of this ./measure_trace.py Wikipedia__1_tab_.json should produce the values that miletus 
saw in crbug.com/399671

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290221

[nduca, 2014-08-13 22:47:34]

lgtm have ernstm review for quick sanity check?

[nednguyen, 2014-08-14 16:52:19]

FYI

[chrishenry, 2014-08-15 17:14:57]

https://codereview.chromium.org/476493002/diff/20001/tools/telemetry/examples...
File tools/telemetry/examples/measure_trace.py (right):

https://codereview.chromium.org/476493002/diff/20001/tools/telemetry/examples...
tools/telemetry/examples/measure_trace.py:62: smoothness_metric.AddResults(
This is specifically for smoothness metric? Do you intend this to support more
in the future? Shouldn't this simply uses the interaction record flags?

Why not extract something from TimelineBasedMeasurement for this?

[nednguyen, 2014-08-15 17:21:26]

On 2014/08/15 17:14:57, chrishenry wrote:
>
https://codereview.chromium.org/476493002/diff/20001/tools/telemetry/examples...
> File tools/telemetry/examples/measure_trace.py (right):
> 
>
https://codereview.chromium.org/476493002/diff/20001/tools/telemetry/examples...
> tools/telemetry/examples/measure_trace.py:62: smoothness_metric.AddResults(
> This is specifically for smoothness metric? Do you intend this to support more
> in the future? Shouldn't this simply uses the interaction record flags?
> 
> Why not extract something from TimelineBasedMeasurement for this?

We totally can do the full set of TimelineBasedMeasurement's metrics. Even
crazier thoughts, timeline_based_measurement and this should share the code path
of pulling out records and measure (https://codereview.chromium.org/439383002/).


I guess I was lazy, and want to see how helpful this tool is first.

[nednguyen, 2014-08-15 22:36:52]

On 2014/08/15 17:21:26, nednguyen wrote:
> On 2014/08/15 17:14:57, chrishenry wrote:
> >
>
https://codereview.chromium.org/476493002/diff/20001/tools/telemetry/examples...
> > File tools/telemetry/examples/measure_trace.py (right):
> > 
> >
>
https://codereview.chromium.org/476493002/diff/20001/tools/telemetry/examples...
> > tools/telemetry/examples/measure_trace.py:62: smoothness_metric.AddResults(
> > This is specifically for smoothness metric? Do you intend this to support
more
> > in the future? Shouldn't this simply uses the interaction record flags?
> > 
> > Why not extract something from TimelineBasedMeasurement for this?
> 
> We totally can do the full set of TimelineBasedMeasurement's metrics. Even
> crazier thoughts, timeline_based_measurement and this should share the code
path
> of pulling out records and measure
(https://codereview.chromium.org/439383002/).
> 
> 
> I guess I was lazy, and want to see how helpful this tool is first.

Updates the code to ignore RUN_SMOOTH_ACTIONS, group interaction records by
name, and use interaction label for page.

[ernstm, 2014-08-15 22:42:27]

On 2014/08/15 22:36:52, nednguyen wrote:
> On 2014/08/15 17:21:26, nednguyen wrote:
> > On 2014/08/15 17:14:57, chrishenry wrote:
> > >
> >
>
https://codereview.chromium.org/476493002/diff/20001/tools/telemetry/examples...
> > > File tools/telemetry/examples/measure_trace.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/476493002/diff/20001/tools/telemetry/examples...
> > > tools/telemetry/examples/measure_trace.py:62:
smoothness_metric.AddResults(
> > > This is specifically for smoothness metric? Do you intend this to support
> more
> > > in the future? Shouldn't this simply uses the interaction record flags?
> > > 
> > > Why not extract something from TimelineBasedMeasurement for this?
> > 
> > We totally can do the full set of TimelineBasedMeasurement's metrics. Even
> > crazier thoughts, timeline_based_measurement and this should share the code
> path
> > of pulling out records and measure
> (https://codereview.chromium.org/439383002/).
> > 
> > 
> > I guess I was lazy, and want to see how helpful this tool is first.
> 
> Updates the code to ignore RUN_SMOOTH_ACTIONS, group interaction records by
> name, and use interaction label for page.

Thanks! LGTM.

[nednguyen, 2014-08-15 22:42:54]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-08-15 22:45:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nednguyen@google.com/476493002/40001

[commit-bot: I haz the power, 2014-08-16 02:32:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-16 03:39:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-16 03:39:14]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[nednguyen, 2014-08-18 06:22:30]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-08-18 06:23:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nednguyen@google.com/476493002/40001

[commit-bot: I haz the power, 2014-08-18 07:39:06]

Committed patchset #2 (40001) as 290221