DescriptionFork of https://codereview.chromium.org/469833003/
Cannot print PDFs
In r180112, I removed some seemly dead code, but that code actually existed to
make some functions on PrintContext virtual. Instead of hacking in virtuals via
a subclass in the web layer, we can just make the functions virtual in the base
class.
I've also added OVERRIDE annotations to catch this sort of error at compile
time. These annotations required me to fix the return type of one of these
functions to match. Finally, I've added a test, which appears to be the first
unit test to exercise this codepath.
BUG=403467
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180220
Patch Set 1 #Patch Set 2 : Wed 08/13/2014 15:15:15.97 #
Messages
Total messages: 7 (0 generated)
|