Python readability review for dbeam@.

third_party/closure_compiler/processor_test.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Test resources processing, i.e. <if> and <include> tag handling."""
 
 import unittest
 from processor import FileCache, Processor, LineNumber
 
@@ skipping 23 matching lines @@
  * @fileoverview Coolest app ever.
  * @author Douglas Crockford (douglas@crockford.com)
  */
 <include src="/global.js">
 debug(global);
 // Here continues checked.js, a swell file.
 """.strip()
 
     self._processor = Processor("/checked.js")
 
   def testInline(self):

[Dan Beam, 2014/08/13 22:06:55]

testName is 10x more popular than test_name in chrome code

  $ git grep -E '^\s+def test_.*\(' -- '*.py' | wc -l
  253

  $ git grep -E '^\s+def test[A-Z].*\(' -- '*.py' | wc -l
  2246

despite the style guide's guidance of method_names().

     self.assertMultiLineEqual("""
 // Copyright 2028 Future Chromium Author dudes.
 /**
  * @fileoverview Coolest app ever.
  * @author Douglas Crockford (douglas@crockford.com)
  */
 // Copyright 2014 Old Chromium Author dudes.
 // Copyright 2002 Older Chromium Author dudes.
 function debug(msg) { if (window.DEBUG) alert(msg); }
 var global = 'type checking!';
@@ skipping 50 matching lines @@
     alert("Oh wow!");
     return "XX";
 
     return "XXI";
   }
 """.strip(), self.processor_.contents)
 
 
 if __name__ == '__main__':
   unittest.main()
+