Python readability review for dbeam@.

third_party/closure_compiler/checker.py

 #!/usr/bin/python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Closure compiler on a JavaScript file to check for errors."""
 
 import argparse
 import os
 import re
@@ skipping 46 matching lines @@
 
   _found_java = False
 
   def __init__(self, verbose=False):
     current_dir = os.path.join(os.path.dirname(__file__))
     self._compiler_jar = os.path.join(current_dir, "lib", "compiler.jar")
     self._runner_jar = os.path.join(current_dir, "runner", "runner.jar")
     self._temp_files = []
     self._verbose = verbose
 
   def _clean_up(self):

[Dan Beam, 2014/08/13 22:06:55]

it seems like _protected_method() is preferred and __private_method() is
discouraged in newer python style guides whereas __private_method() is still in
the older ones.

     if not self._temp_files:
       return
 
     self._debug("Deleting temporary files: %s" % ", ".join(self._temp_files))
     for f in self._temp_files:
       os.remove(f)
     self._temp_files = []
 
   def _debug(self, msg, error=False):
     if self._verbose:
@@ skipping 158 matching lines @@
   for source in opts.sources:
     if not checker.check(source, depends=opts.depends, externs=opts.externs):
       sys.exit(1)
 
     if opts.out_file:
       out_dir = os.path.dirname(opts.out_file)
       if not os.path.exists(out_dir):
         os.makedirs(out_dir)
       # TODO(dbeam): write compiled file to |opts.out_file|.
       open(opts.out_file, "w").write("")
+