LayoutTests/fullscreen/model/remove-first.html - Issue 476433002: Sync fullscreen element removal with the spec

Side by Side Diff: LayoutTests/fullscreen/model/remove-first.html

Issue 476433002: Sync fullscreen element removal with the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Remove the first element on the fullscreen element stack</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script src="../trusted-event.js"></script>

	6 <div id="log"></div>

	7 <div id="first">

	8 <div id="last"></div>

	9 </div>

	10 <script>

	11 async_test(function(t)

	12 {

	13 var first = document.getElementById("first");

	14 trusted_request(first);

	15 document.onfullscreenchange = t.step_func(function()

	16 {

	17 assert_equals(document.fullscreenElement, first);

	18 var last = document.getElementById("last");

	19 trusted_request(last);

	20 document.onfullscreenchange = t.step_func(function()

	21 {

	22 assert_equals(document.fullscreenElement, last);

	23 first.remove();

	24 document.onfullscreenchange = t.step_func(function()

	25 {

	26 assert_equals(document.fullscreenElement, null);

	27 t.done();

	28 });

	29 });

	30 });

	31 });
	falken 2014/08/14 04:12:47 Totally just an idea, but you might consider using Totally just an idea, but you might consider using Promises to avoid this indentation marching. The Service Worker team has been doing so, you can see recent tests in http/tests/serviceworker for examples. It would look something like this: function wait_for_fullscreenchange() { return new Promise(function(resolve) { document.onfullscreenchange = function(e) { resolve(); } }); } async_test(function(t) { var first = document.getElementById("first"); trusted_request(first); return wait_for_fullscreenchange(); }).then(function() { assert_equals(document.fullscreenElement, first); var last = document.getElementById("last"); trusted_request(last); return wait_for_fullscreenchange(); }).then(function() { assert_equals(document.fullscreenElement, last); first.remove(); return wait_for_fullscreenchange(); }).then(function() { assert_equals(document.fullscreenElement, null); t.done(); }).catch(function(error) { assert_unreached(); }); }); philipj_slow 2014/08/14 08:16:29 That looks really nice! Unfortunately, I've been r Show quoted text On 2014/08/14 04:12:47, falken wrote: > Totally just an idea, but you might consider using Promises to avoid this > indentation marching. The Service Worker team has been doing so, you can see > recent tests in http/tests/serviceworker for examples. > > It would look something like this: > > function wait_for_fullscreenchange() { > return new Promise(function(resolve) { > document.onfullscreenchange = function(e) { > resolve(); > } > }); > } > > async_test(function(t) > { > var first = document.getElementById("first"); > trusted_request(first); > return wait_for_fullscreenchange(); > }).then(function() { > assert_equals(document.fullscreenElement, first); > var last = document.getElementById("last"); > trusted_request(last); > return wait_for_fullscreenchange(); > }).then(function() { > assert_equals(document.fullscreenElement, last); > first.remove(); > return wait_for_fullscreenchange(); > }).then(function() { > assert_equals(document.fullscreenElement, null); > t.done(); > }).catch(function(error) { > assert_unreached(); > }); > }); That looks really nice! Unfortunately, I've been running the tests in Opera 12.16, which had the unprefixed API, and depending on Promises would make the tests always fail... I'm really on the fence, so what I think I'm going to do is go with the indentation marching for this CL, see if future tests become equally or more convoluted, and if so try to convert all tests in a single go.
	32 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fullscreen/model/remove-last.html » ('j') | Source/core/dom/FullscreenElementStack.cpp » ('J')