Issue 476423003: [DevTools] Add interstitial events to Inspector domain.

Issue 476423003: [DevTools] Add interstitial events to Inspector domain. (Closed)

Created:
6 years, 4 months ago by dgozman

Modified:
6 years, 4 months ago

Reviewers:
eustas, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

[DevTools] Add interstitial events to Inspector domain. BUG=404631 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180718

Patch Set 1 #

Total comments: 1

Patch Set 2 : empty handling in frontend #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	Source/devtools/front_end/main/Main.js	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
	M	Source/devtools/protocol.json	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/476423003/1

6 years, 4 months ago (2014-08-20 16:13:56 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-08-20 17:10:49 UTC) #5

eustas

A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/488413002/ by eustas@chromium.org. The ...

6 years, 4 months ago (2014-08-21 05:54:14 UTC) #7

eustas

https://codereview.chromium.org/476423003/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/476423003/diff/1/Source/devtools/protocol.json#newcode50 Source/devtools/protocol.json:50: "name": "interstitialShown", /usr/local/google/home/eustas/clients/chrome/src/third_party/WebKit/Source/devtools/front_end/main/Main.js:36: WARNING - property interstitialHidden on interface ...

6 years, 4 months ago (2014-08-21 05:54:38 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/476423003/20001

6 years, 4 months ago (2014-08-21 08:31:43 UTC) #10

commit-bot: I haz the power

6 years, 4 months ago (2014-08-21 15:55:54 UTC) #11

Message was sent while issue was closed.

Committed patchset #2 (20001) as 180718

Expand Messages | Collapse Messages