Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 476373002: [Telemetry] Only call _UpdatePageSetArchivesIfChanged once per PageSet. (Closed)

Created:
6 years, 4 months ago by tonyg
Modified:
6 years, 4 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Only call _UpdatePageSetArchivesIfChanged once per PageSet. This saves about 5s on my MBP. Hard to say what the savings'll be on the bots. This might also help reliability. BUG=388256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290124

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/telemetry/telemetry/page/page_runner.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tonyg
6 years, 4 months ago (2014-08-15 23:01:23 UTC) #1
dtu
The CQ bit was checked by dtu@chromium.org
6 years, 4 months ago (2014-08-15 23:34:53 UTC) #2
dtu
lgtm
6 years, 4 months ago (2014-08-15 23:34:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/476373002/1
6 years, 4 months ago (2014-08-15 23:36:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-16 03:30:24 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 08:04:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 290124

Powered by Google App Engine
This is Rietveld 408576698