Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py

Issue 476363002: NotEnoughFramesError no longer raises an exception. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address further comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py
diff --git a/tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py b/tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py
index 9339509167b74e89eddb7987fdbc26f9ac2f5f69..2875703b578a8068623e1d9075323715deff7ccb 100644
--- a/tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py
+++ b/tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py
@@ -23,7 +23,6 @@ from telemetry.web_perf.metrics.rendering_stats import (
ComputeInputEventLatencies)
from telemetry.web_perf.metrics.rendering_stats import GetInputLatencyEvents
from telemetry.web_perf.metrics.rendering_stats import HasRenderingStats
-from telemetry.web_perf.metrics.rendering_stats import NotEnoughFramesError
from telemetry.web_perf.metrics.rendering_stats import RenderingStats
@@ -302,8 +301,10 @@ class RenderingStatsUnitTest(unittest.TestCase):
timeline_markers = timeline.FindTimelineMarkers(['ActionA', 'ActionB'])
timeline_ranges = [ timeline_bounds.Bounds.CreateFromEvent(marker)
for marker in timeline_markers ]
- self.assertRaises(NotEnoughFramesError, RenderingStats,
- renderer, None, timeline_ranges)
+
+ stats = RenderingStats(renderer, None, timeline_ranges)
+ self.assertEquals(0, len(stats.frame_timestamps[1]))
+
def testFromTimeline(self):
timeline = model.TimelineModel()

Powered by Google App Engine
This is Rietveld 408576698