Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 476353002: Remove webkitIsFullScreen everywhere except in bindings (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
falken, tkent
CC:
blink-reviews, arv+blink, blink-reviews-events_chromium.org, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Remove webkitIsFullScreen everywhere except in bindings It's equivalent to webkitCurrentFullScreenElement != null. BUG=383813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180439

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M Source/core/css/SelectorChecker.cpp View 1 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/dom/DocumentFullscreen.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DocumentFullscreen.cpp View 1 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/dom/DocumentFullscreen.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Fullscreen.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Fullscreen.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FullscreenController.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-08-15 21:57:30 UTC) #1
falken
lgtm
6 years, 4 months ago (2014-08-18 02:48:36 UTC) #2
philipj_slow
rebase
6 years, 4 months ago (2014-08-18 08:45:04 UTC) #3
philipj_slow
tkent, can you please review Source/web?
6 years, 4 months ago (2014-08-18 08:45:37 UTC) #4
tkent
lgtm
6 years, 4 months ago (2014-08-18 08:56:32 UTC) #5
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-18 08:59:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/476353002/20001
6 years, 4 months ago (2014-08-18 09:00:37 UTC) #7
falken
On 2014/08/18 09:00:37, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 4 months ago (2014-08-18 09:04:11 UTC) #8
philipj_slow
On 2014/08/18 09:04:11, falken wrote: > On 2014/08/18 09:00:37, I haz the power (commit-bot) wrote: ...
6 years, 4 months ago (2014-08-18 09:13:28 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 09:46:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180439

Powered by Google App Engine
This is Rietveld 408576698