Source/core/dom/shadow/InsertionPoint.cpp - Issue 476273004: Use Traversal<>::firstAncestor() API more in the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/InsertionPoint.cpp

Issue 476273004: Use Traversal<>::firstAncestor() API more in the code base (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/shadow/InsertionPoint.cpp

diff --git a/Source/core/dom/shadow/InsertionPoint.cpp b/Source/core/dom/shadow/InsertionPoint.cpp

index 9bb7c0c225ed53fd006ed29b17ae1f54c210c348..fb1029415a385788b478bfd5a132380aac8fae29 100644

--- a/Source/core/dom/shadow/InsertionPoint.cpp

+++ b/Source/core/dom/shadow/InsertionPoint.cpp

@@ -135,11 +135,7 @@ bool InsertionPoint::canBeActive() const

{

if (!isInShadowTree())

return false;

- for (Node* node = parentNode(); node; node = node->parentNode()) {

- if (node->isInsertionPoint())

- return false;

- }

- return true;

+ return !Traversal<InsertionPoint>::firstAncestor(*this);

}

bool InsertionPoint::isActive() const

« no previous file with comments | « Source/core/accessibility/AXNodeObject.cpp ('k') | Source/core/html/HTMLAreaElement.cpp » ('j') | no next file with comments »