Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 476263002: Omnibox - Search Provider - Cleanup Keyword Mode's Legal Matches (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mike's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autocomplete/base_search_provider.cc ('K') | « chrome/browser/autocomplete/base_search_provider.cc ('k') | chrome/browser/autocomplete/search_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/search_provider.h
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index d7be6bf878ddb824e3321dd1da30c6541f97bce4..181e1c3f5538e6fbe23d2b933003362e6e009e21 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -229,9 +229,9 @@ class SearchProvider : public BaseSearchProvider,
// be chosen as default.
ACMatches::const_iterator FindTopMatch() const;
- // Checks if suggested relevances violate certain expected constraints.
- // See UpdateMatches() for the use and explanation of these constraints.
- bool HasKeywordDefaultMatchInKeywordMode() const;
+ // Checks if suggested relevances violate an expected constraint.
+ // See UpdateMatches() for the use and explanation of this constraint
+ // and others defined in the code (that don't need helper functions).
msw 2014/08/15 19:06:06 nit: " // and other constraints enforced without
Mark P 2014/08/15 19:14:49 Done.
bool IsTopMatchSearchWithURLInput() const;
// Converts an appropriate number of navigation results in
« chrome/browser/autocomplete/base_search_provider.cc ('K') | « chrome/browser/autocomplete/base_search_provider.cc ('k') | chrome/browser/autocomplete/search_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698