Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 476243003: Add the "serviceWorker" key to the browsingData API. Support in the C++ was (Closed)

Created:
6 years, 4 months ago by not at google - send to devlin
Modified:
6 years, 4 months ago
Reviewers:
jsbell
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add the "serviceWorker" key to the browsingData API. Support in the C++ was added in r288784 but the schema missed out. BUG=388164 R=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290053

Patch Set 1 #

Total comments: 2

Patch Set 2 : name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/common/extensions/api/browsing_data.json View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
not at google - send to devlin
6 years, 4 months ago (2014-08-15 19:29:38 UTC) #1
jsbell
lgtm, sorry about missing this! https://codereview.chromium.org/476243003/diff/1/chrome/common/extensions/api/browsing_data.json File chrome/common/extensions/api/browsing_data.json (right): https://codereview.chromium.org/476243003/diff/1/chrome/common/extensions/api/browsing_data.json#newcode112 chrome/common/extensions/api/browsing_data.json:112: "description": "Service workers." Nit: ...
6 years, 4 months ago (2014-08-15 20:52:05 UTC) #2
not at google - send to devlin
Np, totally serendipitous that I noticed this at all. https://codereview.chromium.org/476243003/diff/1/chrome/common/extensions/api/browsing_data.json File chrome/common/extensions/api/browsing_data.json (right): https://codereview.chromium.org/476243003/diff/1/chrome/common/extensions/api/browsing_data.json#newcode112 chrome/common/extensions/api/browsing_data.json:112: ...
6 years, 4 months ago (2014-08-15 21:41:57 UTC) #3
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 4 months ago (2014-08-15 21:42:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/476243003/20001
6 years, 4 months ago (2014-08-15 21:43:07 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-15 23:35:27 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 23:41:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290053

Powered by Google App Engine
This is Rietveld 408576698