Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 476233002: Do not request vsync on touch if using synchronous compositor (Closed)

Created:
6 years, 4 months ago by boliu
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jdduke (slow), nona+watch_chromium.org, penghuang+watch_chromium.org, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Do not request vsync on touch if using synchronous compositor Nothing registers for the callback in WasShown if using synchronous compositor, so this does not change any behavior. So this is only removing unneeded RequestVSyncUpdate BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289997

Patch Set 1 #

Patch Set 2 : observing_root_window_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
boliu
PTAL
6 years, 4 months ago (2014-08-15 17:59:33 UTC) #1
aelias_OOO_until_Jul13
Hmm, I don't like unnecessarily forking logic depending on mode booleans. Could we check if ...
6 years, 4 months ago (2014-08-15 18:16:23 UTC) #2
boliu
On 2014/08/15 18:16:23, aelias wrote: > Hmm, I don't like unnecessarily forking logic depending on ...
6 years, 4 months ago (2014-08-15 18:19:55 UTC) #3
aelias_OOO_until_Jul13
lgtm
6 years, 4 months ago (2014-08-15 18:26:39 UTC) #4
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 4 months ago (2014-08-15 18:26:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/476233002/20001
6 years, 4 months ago (2014-08-15 18:32:30 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 20:25:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289997

Powered by Google App Engine
This is Rietveld 408576698