Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 47623004: chromium-status: tests: handle -vv and -vvv flags (Closed)

Created:
7 years, 1 month ago by vapier
Modified:
7 years, 1 month ago
Reviewers:
cmp
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

chromium-status: tests: handle -vv and -vvv flags People like to pack flags like -vv rather than doing -v -v. Support that too. BUG=chromium:314501 TEST=`./tests/main_test.py -vv` uses more verbose logging Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=234178

Patch Set 1 #

Total comments: 2

Patch Set 2 : switch to optparse #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M tests/main_test.py View 1 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vapier
7 years, 1 month ago (2013-11-04 20:17:50 UTC) #1
cmp
https://codereview.chromium.org/47623004/diff/1/tests/main_test.py File tests/main_test.py (right): https://codereview.chromium.org/47623004/diff/1/tests/main_test.py#newcode364 tests/main_test.py:364: (sys.argv.count('-vvv') * 3))]) Does optparse natively support this? If ...
7 years, 1 month ago (2013-11-04 22:27:48 UTC) #2
vapier
https://codereview.chromium.org/47623004/diff/1/tests/main_test.py File tests/main_test.py (right): https://codereview.chromium.org/47623004/diff/1/tests/main_test.py#newcode364 tests/main_test.py:364: (sys.argv.count('-vvv') * 3))]) shouldn't be hard to rewrite with ...
7 years, 1 month ago (2013-11-04 22:30:23 UTC) #3
vapier
this version handles -v -vv -vvvvvv sanely. it will barf if you do something like ...
7 years, 1 month ago (2013-11-04 23:52:48 UTC) #4
cmp
lgtm
7 years, 1 month ago (2013-11-10 16:08:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vapier@chromium.org/47623004/70001
7 years, 1 month ago (2013-11-10 16:08:53 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-10 16:09:10 UTC) #7
Message was sent while issue was closed.
Change committed as 234178

Powered by Google App Engine
This is Rietveld 408576698