Source/core/platform/animation/TimingFunction.h - Issue 47623002: Fix more warnings on linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/animation/TimingFunction.h

Issue 47623002: Fix more warnings on linux (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix sign-compare and do not yet turn on -Wall. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/html/canvas/WebGLRenderingContext.cpp ('k') | Source/core/platform/graphics/WidthCache.h » ('j') | Source/core/platform/graphics/chromium/ImageDecodingStore.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/animation/TimingFunction.h

diff --git a/Source/core/platform/animation/TimingFunction.h b/Source/core/platform/animation/TimingFunction.h

index 39ce2b40bfc6523cd492ae701eefefc41c698288..342925772719f6112f7767545cc02fe44402e40d 100644

--- a/Source/core/platform/animation/TimingFunction.h

+++ b/Source/core/platform/animation/TimingFunction.h

@@ -274,11 +274,10 @@ public:

RELEASE_ASSERT_WITH_MESSAGE(fraction >= 0 && fraction <= 1, "Web Animations not yet implemented: Timing function behavior outside the range [0, 1] is not yet specified");

ASSERT(!m_segments.isEmpty());

ASSERT(m_segments.last().max() == 1);

- const Segment* segment;

- for (size_t i = 0; i < m_segments.size(); ++i) {

- segment = &m_segments[i];

- if (fraction < segment->max())

- break;

+ size_t i = 0;

+ const Segment* segment = &m_segments[i++];

+ while (fraction >= segment->max() && i < m_segments.size()) {

+ segment = &m_segments[i++];

}

return segment->evaluate(fraction, accuracy);

}