Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: Source/bindings/v8/ScriptDebugServer.cpp

Issue 47623002: Fix more warnings on linux (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix sign-compare and do not yet turn on -Wall. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ScriptDebugServer.cpp
diff --git a/Source/bindings/v8/ScriptDebugServer.cpp b/Source/bindings/v8/ScriptDebugServer.cpp
index efa69665331f57709365cba1edd123ca5a1816e2..5ff47fc8146ee5e41b014c42c11b2af26e3c45a2 100644
--- a/Source/bindings/v8/ScriptDebugServer.cpp
+++ b/Source/bindings/v8/ScriptDebugServer.cpp
@@ -415,16 +415,14 @@ void ScriptDebugServer::v8DebugEventCallback(const v8::Debug::EventDetails& even
bool ScriptDebugServer::executeSkipPauseRequest(ScriptDebugListener::SkipPauseRequest request, v8::Handle<v8::Object> executionState)
{
- const char* v8MethodName;
switch (request) {
case ScriptDebugListener::NoSkip:
return false;
case ScriptDebugListener::Continue:
return true;
case ScriptDebugListener::StepInto:
- v8MethodName = stepIntoV8MethodName;
case ScriptDebugListener::StepOut:
- v8MethodName = stepOutV8MethodName;
+ break;
}
v8::Handle<v8::Value> argv[] = { executionState };
callDebuggerMethod(stepIntoV8MethodName, 1, argv);
« no previous file with comments | « no previous file | Source/core/dom/DOMURLUtils.h » ('j') | Source/core/platform/graphics/chromium/ImageDecodingStore.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698