Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: Source/core/platform/graphics/WidthCache.h

Issue 47623002: Fix more warnings on linux (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix sign-compare and do not yet turn on -Wall. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 struct SmallStringKeyHash { 100 struct SmallStringKeyHash {
101 static unsigned hash(const SmallStringKey& key) { return key.hash(); } 101 static unsigned hash(const SmallStringKey& key) { return key.hash(); }
102 static bool equal(const SmallStringKey& a, const SmallStringKey& b) { re turn a == b; } 102 static bool equal(const SmallStringKey& a, const SmallStringKey& b) { re turn a == b; }
103 static const bool safeToCompareToEmptyOrDeleted = true; // Empty and del eted values have lengths that are not equal to any valid length. 103 static const bool safeToCompareToEmptyOrDeleted = true; // Empty and del eted values have lengths that are not equal to any valid length.
104 }; 104 };
105 105
106 struct SmallStringKeyHashTraits : WTF::SimpleClassHashTraits<SmallStringKey> { 106 struct SmallStringKeyHashTraits : WTF::SimpleClassHashTraits<SmallStringKey> {
107 static const bool hasIsEmptyValueFunction = true; 107 static const bool hasIsEmptyValueFunction = true;
108 static bool isEmptyValue(const SmallStringKey& key) { return key.isHashT ableEmptyValue(); } 108 static bool isEmptyValue(const SmallStringKey& key) { return key.isHashT ableEmptyValue(); }
109 static const bool needsDestruction = false; 109 static const bool needsDestruction = false;
110 static const int minimumTableSize = 16; 110 static const unsigned minimumTableSize = 16;
111 }; 111 };
112 112
113 friend bool operator==(const SmallStringKey&, const SmallStringKey&); 113 friend bool operator==(const SmallStringKey&, const SmallStringKey&);
114 114
115 public: 115 public:
116 WidthCache() 116 WidthCache()
117 : m_interval(s_maxInterval) 117 : m_interval(s_maxInterval)
118 , m_countdown(m_interval) 118 , m_countdown(m_interval)
119 { 119 {
120 } 120 }
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 inline bool operator==(const WidthCache::SmallStringKey& a, const WidthCache::Sm allStringKey& b) 207 inline bool operator==(const WidthCache::SmallStringKey& a, const WidthCache::Sm allStringKey& b)
208 { 208 {
209 if (a.length() != b.length()) 209 if (a.length() != b.length())
210 return false; 210 return false;
211 return WTF::equal(a.characters(), b.characters(), a.length()); 211 return WTF::equal(a.characters(), b.characters(), a.length());
212 } 212 }
213 213
214 } // namespace WebCore 214 } // namespace WebCore
215 215
216 #endif // WidthCache_h 216 #endif // WidthCache_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698