Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 476223003: Use tighter typing for Document::ownerElement() return value (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
adamk, rwlbuis
CC:
aandrey+blink_chromium.org, aboxhall, apavlov+blink_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dmazzoni, eae+blinkwatch, eustas+blink_chromium.org, jchaffraix+rendering, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, rwlbuis, rune+blink, sergeyv+blink_chromium.org, sof, vsevik+blink_chromium.org, yurys+blink_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Use tighter typing for Document::ownerElement() return value Use tighter typing for Document::ownerElement() return value. It returns an HTMLFrameOwnerElement* but a lot of callers assign it to an Element* variable. This gets rid of a few unnecessary type checks and avoids an unnecessary isHTMLElement() check in isHTMLFrameElementBase() in several cases. R=adamk@chromium.org, rob.buis@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -23 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 1 chunk +5 lines, -9 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 4 months ago (2014-08-15 22:10:59 UTC) #1
adamk
lgtm
6 years, 4 months ago (2014-08-16 00:51:23 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-16 00:52:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/476223003/1
6 years, 4 months ago (2014-08-16 00:52:39 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 01:39:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 180400

Powered by Google App Engine
This is Rietveld 408576698