Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 476203003: Add alias mapping for Noto Sans CJK for ja/hans (Closed)

Created:
6 years, 4 months ago by jungshik at Google
Modified:
6 years, 4 months ago
Reviewers:
bungeman-skia, reed2
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add alias mapping for Noto Sans CJK for ja/hans Chrome/Chromium OS are getting a brand new CJK fonts (Noto Sans CJK). We want them to be used in place of common Japanese and Simplified Chinese sans-serif fonts. BUG=chromium:399080 TEST=With CrOS CL (https://chromium-review.googlesource.com/#/c/212624/), web pages using 'Simhei' and 'MSP Gothic' are rendered with Noto Sans CJK. Committed: https://skia.googlesource.com/skia/+/ad77e55cc0a29fa2d5cb76077d2e4139a7ebabff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/ports/SkFontConfigInterface_direct.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jungshik at Google
Hi Mike, can you take a quick look? Thanks !
6 years, 4 months ago (2014-08-15 18:46:50 UTC) #1
jungshik at Google
Ben, can you take a look? Thanks !
6 years, 4 months ago (2014-08-15 22:06:18 UTC) #2
bungeman-skia
lgtm I'm currently working on Android, but soon I'm hoping to get back around to ...
6 years, 4 months ago (2014-08-15 22:23:18 UTC) #3
jungshik at Google
On 2014/08/15 22:23:18, bungeman1 wrote: > lgtm > > I'm currently working on Android, but ...
6 years, 4 months ago (2014-08-15 23:25:23 UTC) #4
jungshik at Google
The CQ bit was checked by jshin@chromium.org
6 years, 4 months ago (2014-08-16 09:42:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jshin@chromium.org/476203003/1
6 years, 4 months ago (2014-08-16 09:43:16 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 15:07:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as ad77e55cc0a29fa2d5cb76077d2e4139a7ebabff

Powered by Google App Engine
This is Rietveld 408576698