Issue 476203002: Revert 289634 "Battery Status API: implementation for Windows."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 476203002: Revert 289634 "Battery Status API: implementation for Windows." (Closed)

Created:
6 years, 4 months ago by jschuh

Modified:
6 years, 4 months ago

Reviewers:
timvolodine

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/branches/2124/src/

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert 289634 "Battery Status API: implementation for Windows." Broke Win XP > Battery Status API: implementation for Windows. > > Implementation of the Battery Status API for the Windows platform. > Implementation uses a message window to receive battery notifications. > On versions prior to Vista there is limited support as the > RegisterPowerSettingNotification function is not available. > > BUG=122593 > TEST=http://jsbin.com/battery-status-test (manual) > > Review URL: https://codereview.chromium.org/447853002 TBR=timvolodine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289901

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -316 lines)			Patch
D	content/browser/battery_status/battery_status_manager_win.h	View	1 chunk	+0 lines, -26 lines	0 comments	Download
D	content/browser/battery_status/battery_status_manager_win.cc	View	1 chunk	+0 lines, -206 lines	0 comments	Download
D	content/browser/battery_status/battery_status_manager_win_unittest.cc	View	1 chunk	+0 lines, -80 lines	0 comments	Download
M	content/content_browser.gypi	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

timvolodine

6 years, 4 months ago (2014-08-15 16:43:52 UTC) #3

Message was sent while issue was closed.

On 2014/08/15 16:23:46, Justin Schuh wrote:
> Committed patchset #1 manually as r289901.

Justin, did you revert this on chrome-dev tot? I don't see it in the waterfall.

Expand Messages | Collapse Messages