Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 476193003: User Manager: fix text blurriness and "remove" button style (Closed)

Created:
6 years, 4 months ago by noms (inactive)
Modified:
6 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

User Manager: fix text blurriness and "remove" button style 1. The text is blurry because we use a transform: scale3d(), which on non-retina desktop Chrome is blurry. I assume there is a reason why CrOS chose a scale3d() so I only made this change for the desktop. 2. This leads to a webkit bug (crbug.com/406529) where transforms and opacity transitions do not play well together, so I've removed the opacity transition on the action-area-box. Also: 3. Fixed the focus style on the "remove user" button to not be the ugly blue default but match the gmail style. BUG=399683, 403784 TEST=Start Chrome with -enable-new-avatar-menu. Click on "Switch person". The profile names in the user manager should not be blurry, and hovering over the pods should not be janky. Committed: https://crrev.com/0f76d30c42ca7c794562f64e642e1db4d405caa2 Cr-Commit-Position: refs/heads/master@{#291640}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : border comes before box. alphabets! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M chrome/browser/resources/user_manager/user_manager.css View 1 4 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
noms (inactive)
6 years, 4 months ago (2014-08-22 20:39:39 UTC) #1
xiyuan
lgtm https://codereview.chromium.org/476193003/diff/20001/chrome/browser/resources/user_manager/user_manager.css File chrome/browser/resources/user_manager/user_manager.css (right): https://codereview.chromium.org/476193003/diff/20001/chrome/browser/resources/user_manager/user_manager.css#newcode180 chrome/browser/resources/user_manager/user_manager.css:180: border: 1px solid transparent !important; nit: alpha sort ...
6 years, 4 months ago (2014-08-22 20:48:06 UTC) #2
noms (inactive)
https://codereview.chromium.org/476193003/diff/20001/chrome/browser/resources/user_manager/user_manager.css File chrome/browser/resources/user_manager/user_manager.css (right): https://codereview.chromium.org/476193003/diff/20001/chrome/browser/resources/user_manager/user_manager.css#newcode180 chrome/browser/resources/user_manager/user_manager.css:180: border: 1px solid transparent !important; On 2014/08/22 20:48:06, xiyuan ...
6 years, 3 months ago (2014-08-23 19:08:11 UTC) #3
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 3 months ago (2014-08-23 19:08:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/476193003/40001
6 years, 3 months ago (2014-08-23 19:09:45 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-23 19:59:22 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-23 20:45:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1693)
6 years, 3 months ago (2014-08-23 20:45:43 UTC) #8
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 3 months ago (2014-08-25 03:47:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/476193003/40001
6 years, 3 months ago (2014-08-25 03:48:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (40001) as b4d1de3e1e6949142035d1051b64ccfc12de0351
6 years, 3 months ago (2014-08-25 04:41:43 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:33:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f76d30c42ca7c794562f64e642e1db4d405caa2
Cr-Commit-Position: refs/heads/master@{#291640}

Powered by Google App Engine
This is Rietveld 408576698