Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 476153002: DevTools: Make the way inspectorFrontend is referenced in agents consistent in all of them. (Closed)

Created:
6 years, 4 months ago by vsevik
Modified:
6 years, 4 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Make the way inspectorFrontend is referenced in agents consistent in all of them. R=yurys, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M Source/core/inspector/InspectorDOMStorageAgent.h View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorInspectorAgent.h View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorInspectorAgent.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.cpp View 9 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vsevik
PTAL
6 years, 4 months ago (2014-08-15 13:48:35 UTC) #1
yurys
lgtm
6 years, 4 months ago (2014-08-15 13:53:32 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 4 months ago (2014-08-15 14:55:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/476153002/1
6 years, 4 months ago (2014-08-15 14:56:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-15 16:56:35 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 17:54:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180381

Powered by Google App Engine
This is Rietveld 408576698