Rename platform specific wifi data provider classes.

Rename platform specific wifi data provider classes.

For consistency with the file names, and with WifiDataProviderLinux and WifiDataProviderChromeOS the platform token is a suffix.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290321

[Michael van Ouwerkerk, 2014-08-15 15:01:16]

Hi Tim, please take a look.

[timvolodine, 2014-08-15 18:00:59]

https://codereview.chromium.org/476133003/diff/1/content/browser/geolocation/...
File content/browser/geolocation/wifi_data_provider_win.h (right):

https://codereview.chromium.org/476133003/diff/1/content/browser/geolocation/...
content/browser/geolocation/wifi_data_provider_win.h:13: class CONTENT_EXPORT
WifiDataProviderWin32 : public WifiDataProviderCommon {
is there a reason this is called win32 instead of simply win?

[Michael van Ouwerkerk, 2014-08-18 10:56:04]

On 2014/08/15 18:00:59, timvolodine wrote:
> WifiDataProviderWin32 : public WifiDataProviderCommon {
> is there a reason this is called win32 instead of simply win?

No good reason afaik. Removed.

[timvolodine, 2014-08-18 14:52:54]

lgtm with my comment addressed ;)

https://codereview.chromium.org/476133003/diff/40001/content/browser/geolocat...
File content/browser/geolocation/wifi_data_provider_unittest_win.cc (right):

https://codereview.chromium.org/476133003/diff/40001/content/browser/geolocat...
content/browser/geolocation/wifi_data_provider_unittest_win.cc:1: // Copyright
(c) 2010 The Chromium Authors. All rights reserved.
I think it much more common to have win_unittest.cc instead of unittest_win.cc
(try a seach in chromium codebase). It makes sense to have a win_unittest
because there are wifi_data_provider_win.* files. Could you rename this file for
consistency?

[Michael van Ouwerkerk, 2014-08-18 15:09:08]

Thanks Tim!

https://codereview.chromium.org/476133003/diff/40001/content/browser/geolocat...
File content/browser/geolocation/wifi_data_provider_unittest_win.cc (right):

https://codereview.chromium.org/476133003/diff/40001/content/browser/geolocat...
content/browser/geolocation/wifi_data_provider_unittest_win.cc:1: // Copyright
(c) 2010 The Chromium Authors. All rights reserved.
On 2014/08/18 14:52:54, timvolodine wrote:
> I think it much more common to have win_unittest.cc instead of unittest_win.cc
> (try a seach in chromium codebase). It makes sense to have a win_unittest
> because there are wifi_data_provider_win.* files. Could you rename this file
for
> consistency?

Agreed, done.

[Michael van Ouwerkerk, 2014-08-18 15:09:14]

The CQ bit was checked by mvanouwerkerk@chromium.org

[commit-bot: I haz the power, 2014-08-18 15:09:43]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/476133003/6...

[commit-bot: I haz the power, 2014-08-18 18:19:56]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-18 19:18:05]

Committed patchset #4 (60001) as 290321