Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 476133002: [Profiles] Downloading high res avatars should do nothing on non-desktop (Closed)

Created:
6 years, 4 months ago by noms (inactive)
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[Profiles] Downloading high res avatars should do nothing on non-desktop BUG=404066 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289964

Patch Set 1 #

Patch Set 2 : disable test on non-desktop too #

Patch Set 3 : typos. srsly. >_< #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/profiles/profile_info_cache.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
noms (inactive)
6 years, 4 months ago (2014-08-15 13:29:54 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 4 months ago (2014-08-15 14:16:23 UTC) #2
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 4 months ago (2014-08-15 14:23:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/476133002/20001
6 years, 4 months ago (2014-08-15 14:27:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 15:40:55 UTC) #5
noms (inactive)
The CQ bit was unchecked by noms@chromium.org
6 years, 4 months ago (2014-08-15 15:41:52 UTC) #6
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 4 months ago (2014-08-15 15:45:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/476133002/60001
6 years, 4 months ago (2014-08-15 15:48:24 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 18:29:43 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 19:05:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (60001) as 289964

Powered by Google App Engine
This is Rietveld 408576698