content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java - Issue 476113004: Replace overdraw_bottom_height with top_controls_layout_height.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

Issue 476113004: Replace overdraw_bottom_height with top_controls_layout_height. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix ScrollViewportRounding test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | content/public/test/render_view_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

index 2c32f673962a4626b2f4c7b9cac2867c6173b43b..84d84b66e473045dce2d27b8c1d2ca79620865da 100644

--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

@@ -251,10 +251,9 @@ public class DOMUtils {

Rect bounds = getNodeBounds(viewCore, nodeName);

Assert.assertNotNull("Failed to get DOM element bounds of '" + nodeName + "'.", bounds);

- int clickX = (int) viewCore.getRenderCoordinates().fromLocalCssToPix(bounds.exactCenterX())

- + viewCore.getViewportSizeOffsetWidthPix();

+ int clickX = (int) viewCore.getRenderCoordinates().fromLocalCssToPix(bounds.exactCenterX());

int clickY = (int) viewCore.getRenderCoordinates().fromLocalCssToPix(bounds.exactCenterY())

- + viewCore.getViewportSizeOffsetHeightPix();

+ + viewCore.getTopControlsLayoutHeightPix();

return new int[] { clickX, clickY };

}