Chromium Code Reviews| Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java |
| diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java |
| index aed113e8e1d25acd9d9ce71cff835df784fd54b8..a68fa7f998a9ea7e265e3377f2760fe3682c3929 100644 |
| --- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java |
| +++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java |
| @@ -260,7 +260,6 @@ public class ContentViewCore |
| private int mViewportHeightPix; |
| private int mPhysicalBackingWidthPix; |
| private int mPhysicalBackingHeightPix; |
| - private int mOverdrawBottomHeightPix; |
| private int mViewportSizeOffsetWidthPix; |
| private int mViewportSizeOffsetHeightPix; |
| @@ -932,12 +931,6 @@ public class ContentViewCore |
| public int getPhysicalBackingHeightPix() { return mPhysicalBackingHeightPix; } |
| /** |
| - * @return Amount the output surface extends past the bottom of the window viewport. |
| - */ |
| - @CalledByNative |
| - public int getOverdrawBottomHeightPix() { return mOverdrawBottomHeightPix; } |
| - |
| - /** |
| * @return The amount to shrink the viewport relative to {@link #getViewportWidthPix()}. |
| */ |
| @CalledByNative |
| @@ -1580,18 +1573,7 @@ public class ContentViewCore |
| } |
| } |
| - /** |
| - * Called when the amount the surface is overdrawing off the bottom has changed. |
| - * @param overdrawHeightPix The overdraw height. |
| - */ |
| public void onOverdrawBottomHeightChanged(int overdrawHeightPix) { |
|
Ted C
2014/08/19 01:14:28
TODO/Deprecation to remove this.
aelias_OOO_until_Jul13
2014/08/19 21:28:39
Done.
|
| - if (mOverdrawBottomHeightPix == overdrawHeightPix) return; |
| - |
| - mOverdrawBottomHeightPix = overdrawHeightPix; |
| - |
| - if (mNativeContentViewCore != 0) { |
| - nativeWasResized(mNativeContentViewCore); |
| - } |
| } |
| private void updateAfterSizeChanged() { |
| @@ -2220,8 +2202,7 @@ public class ContentViewCore |
| float pageScaleFactor, float minPageScaleFactor, float maxPageScaleFactor, |
| float contentWidth, float contentHeight, |
| float viewportWidth, float viewportHeight, |
| - float controlsOffsetYCss, float contentOffsetYCss, |
| - float overdrawBottomHeightCss) { |
| + float controlsOffsetYCss, float contentOffsetYCss) { |
| TraceEvent.begin("ContentViewCore:updateFrameInfo"); |
| // Adjust contentWidth/Height to be always at least as big as |
| // the actual viewport (as set by onSizeChanged). |
| @@ -2280,9 +2261,8 @@ public class ContentViewCore |
| // Update offsets for fullscreen. |
| final float controlsOffsetPix = controlsOffsetYCss * deviceScale; |
| - final float overdrawBottomHeightPix = overdrawBottomHeightCss * deviceScale; |
| getContentViewClient().onOffsetsForFullscreenChanged( |
| - controlsOffsetPix, contentOffsetYPix, overdrawBottomHeightPix); |
| + controlsOffsetPix, contentOffsetYPix, 0); |
|
Ted C
2014/08/19 01:14:28
Same here for the cleanup to no longer pass 0.
aelias_OOO_until_Jul13
2014/08/19 21:28:39
Done.
|
| if (mBrowserAccessibilityManager != null) { |
| mBrowserAccessibilityManager.notifyFrameInfoInitialized(); |