Issue 476113003: Revert 289433 "Refactor pooling logic into a helper method"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 476113003: Revert 289433 "Refactor pooling logic into a helper method" (Closed)

Created:
6 years, 4 months ago by Ryan Hamilton

Modified:
6 years, 4 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 289433 "Refactor pooling logic into a helper method" Reason for revert: Causes crashes in canary. > Refactor pooling logic into a helper method > Disable pooling when there are cert errors. > Disable pooling when pinning does not match for the new host. > > BUG=398925 > > Review URL: https://codereview.chromium.org/425803014 TBR=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289937

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -292 lines)			Patch
M	trunk/src/net/http/http_network_session.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/net/quic/quic_client_session.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/net/quic/quic_client_session.cc	View	5 chunks	+22 lines, -6 lines	0 comments	Download
M	trunk/src/net/quic/quic_client_session_test.cc	View	7 chunks	+10 lines, -54 lines	0 comments	Download
M	trunk/src/net/quic/quic_http_stream_test.cc	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/net/quic/quic_stream_factory.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/net/quic/quic_stream_factory.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/net/quic/quic_stream_factory_test.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	trunk/src/net/socket/ssl_client_socket_pool_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/net/spdy/spdy_session.h	View	4 chunks	+0 lines, -11 lines	0 comments	Download
M	trunk/src/net/spdy/spdy_session.cc	View	4 chunks	+12 lines, -43 lines	0 comments	Download
M	trunk/src/net/spdy/spdy_session_pool.h	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/net/spdy/spdy_session_pool.cc	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/net/spdy/spdy_session_unittest.cc	View	4 chunks	+3 lines, -107 lines	0 comments	Download
M	trunk/src/net/spdy/spdy_test_utils.h	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	trunk/src/net/spdy/spdy_test_utils.cc	View	2 chunks	+0 lines, -33 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

6 years, 4 months ago (2014-08-15 18:09:29 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r289937 (tree was closed).

Expand Messages | Collapse Messages