PRESUBMIT.py - Issue 476113002: Tolerate HarfBuzz include order for generated headers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 476113002: Tolerate HarfBuzz include order for generated headers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@harfbuzzroll0935

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index ec9611d2650755e069d769bae7c87023df5f4d9e..edbf84aadb4d22f81bb0d005db991dfc407d8ceb 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -651,7 +651,7 @@ def _CheckIncludeOrderInFile(input_api, f, changed_linenums):

# check.

uncheckable_includes_pattern = input_api.re.compile(

r'\s*#include '

- '("ipc/.*macros\.h"|<windows\.h>|".*gl.*autogen.h")\s*')

+ '("ipc/.*macros\.h"|<windows\.h>|".*gl.*autogen.h"|"hb.*-(private|table).hh")\s*')

contents = f.NewContents()

warnings = []

« no previous file with comments | « no previous file | no next file » | no next file with comments »