chrome/chrome_browser_extensions.gypi - Issue 476103002: Make DisplayInfoProvider an interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_extensions.gypi

Issue 476103002: Make DisplayInfoProvider an interface (Closed) Base URL: git@github.com:tmpsantos/chromium.git@display_info

Patch Set: Added a comment about a global intentionally leaking. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_browser_extensions.gypi

diff --git a/chrome/chrome_browser_extensions.gypi b/chrome/chrome_browser_extensions.gypi

index 368278441b0e278715ed9afe0d63f9da768de06c..2dc6878d691b5a5e0a2d521194b01ee61d364106 100644

--- a/chrome/chrome_browser_extensions.gypi

+++ b/chrome/chrome_browser_extensions.gypi

@@ -514,9 +514,6 @@

'browser/extensions/api/system_cpu/system_cpu_api.h',

'browser/extensions/api/system_display/display_info_provider.cc',

'browser/extensions/api/system_display/display_info_provider.h',

- 'browser/extensions/api/system_display/display_info_provider_chromeos.cc',

- 'browser/extensions/api/system_display/display_info_provider_mac.cc',

- 'browser/extensions/api/system_display/display_info_provider_win.cc',

'browser/extensions/api/system_display/system_display_api.cc',

'browser/extensions/api/system_display/system_display_api.h',

'browser/extensions/api/system_indicator/system_indicator_api.h',

@@ -650,6 +647,12 @@

'browser/extensions/dev_mode_bubble_controller.h',

'browser/extensions/devtools_util.cc',

'browser/extensions/devtools_util.h',

+ 'browser/extensions/display_info_provider_chromeos.cc',

+ 'browser/extensions/display_info_provider_chromeos.h',

+ 'browser/extensions/display_info_provider_mac.cc',

+ 'browser/extensions/display_info_provider_mac.h',

+ 'browser/extensions/display_info_provider_win.cc',

+ 'browser/extensions/display_info_provider_win.h',

'browser/extensions/error_console/error_console.cc',

'browser/extensions/error_console/error_console.h',

'browser/extensions/event_router_forwarder.cc',

@@ -1133,7 +1136,8 @@

}],

['OS!="win" and chromeos==0', {

'sources': [

- 'browser/extensions/api/system_display/display_info_provider_aura.cc',

+ 'browser/extensions/display_info_provider_aura.cc',

+ 'browser/extensions/display_info_provider_aura.h',

}],

['enable_app_list==1', {