Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Unified Diff: chrome/browser/extensions/display_info_provider_mac.cc

Issue 476103002: Make DisplayInfoProvider an interface (Closed) Base URL: git@github.com:tmpsantos/chromium.git@display_info
Patch Set: Added a comment about a global intentionally leaking. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/display_info_provider_mac.cc
diff --git a/chrome/browser/extensions/api/system_display/display_info_provider_mac.cc b/chrome/browser/extensions/display_info_provider_mac.cc
similarity index 49%
rename from chrome/browser/extensions/api/system_display/display_info_provider_mac.cc
rename to chrome/browser/extensions/display_info_provider_mac.cc
index 84a610542ce54614c2b3c3b2a1b95cc887a81831..ef611073762909b6b7d4338c9326dbd8c9f07793 100644
--- a/chrome/browser/extensions/api/system_display/display_info_provider_mac.cc
+++ b/chrome/browser/extensions/display_info_provider_mac.cc
@@ -2,21 +2,33 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/extensions/api/system_display/display_info_provider.h"
+#include "chrome/browser/extensions/display_info_provider_mac.h"
namespace extensions {
-bool DisplayInfoProvider::SetInfo(const std::string& display_id,
+DisplayInfoProviderMac::DisplayInfoProviderMac() {
+}
+
+DisplayInfoProviderMac::~DisplayInfoProviderMac() {
+}
+
+bool DisplayInfoProviderMac::SetInfo(
+ const std::string& display_id,
const api::system_display::DisplayProperties& info,
std::string* error) {
- *error = "Not Implemented";
+ *error = "Not implemented";
return false;
}
-void DisplayInfoProvider::UpdateDisplayUnitInfoForPlatform(
+void DisplayInfoProviderMac::UpdateDisplayUnitInfoForPlatform(
const gfx::Display& display,
extensions::api::system_display::DisplayUnitInfo* unit) {
NOTIMPLEMENTED();
}
+// static
+DisplayInfoProvider* DisplayInfoProvider::Create() {
+ return new DisplayInfoProviderMac();
+}
+
} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/display_info_provider_mac.h ('k') | chrome/browser/extensions/display_info_provider_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698