Issue 476083002: Cleanup FrameLoader::opener() to return a Frame*.

Issue 476083002: Cleanup FrameLoader::opener() to return a Frame*. (Closed)

Created:
6 years, 4 months ago by dcheng

Modified:
6 years, 4 months ago

Reviewers:
Nate Chapin

CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Cleanup FrameLoader::opener() to return a Frame*. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180412

Patch Set 2 : Remove unused forward declare. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
M	Source/core/frame/LocalDOMWindow.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/loader/FrameLoader.h	View	1	3 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/loader/FrameLoader.cpp	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nate Chapin

LGTM https://codereview.chromium.org/476083002/diff/1/Source/core/loader/FrameLoader.h File Source/core/loader/FrameLoader.h (right): https://codereview.chromium.org/476083002/diff/1/Source/core/loader/FrameLoader.h#newcode64 Source/core/loader/FrameLoader.h:64: class Resource; Not your fault, but is this ...

6 years, 4 months ago (2014-08-15 18:59:17 UTC) #2

dcheng

https://codereview.chromium.org/476083002/diff/1/Source/core/loader/FrameLoader.h File Source/core/loader/FrameLoader.h (right): https://codereview.chromium.org/476083002/diff/1/Source/core/loader/FrameLoader.h#newcode64 Source/core/loader/FrameLoader.h:64: class Resource; On 2014/08/15 18:59:17, Nate Chapin wrote: > ...

6 years, 4 months ago (2014-08-16 19:56:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/476083002/20001

6 years, 4 months ago (2014-08-16 19:57:01 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-08-16 21:11:54 UTC) #6

commit-bot: I haz the power

6 years, 4 months ago (2014-08-16 21:44:53 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (20001) as 180412

Expand Messages | Collapse Messages