Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issue 476073002: Revert of Factor Chrome details out of update manifest fetching. (Closed)

Created:
6 years, 4 months ago by Nikita (slow)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Ilya Sherman, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Factor Chrome details out of update manifest fetching. (patchset #5 of https://codereview.chromium.org/465543004/) Reason for revert: Doesn't compile on all chromium.chrome buildbots (official). Original issue's description: > Factor Chrome details out of update manifest fetching. > > This establishes a ManifestFetchDataDelegate for use > by ExtensionDownloader and ManifestFetchData, and moves > ManifestFetchData into //extensions/browser/updater. > > The delegate provides implementation details for > update manifest fetching, including brand code, > boilerplate query parameters, and ping data. > > Chrome's implementation has knowledge of the > Google brand, the metrics service, and Omaha-specific > query parameters necessary for CRX item queries. > > BUG=398671 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289800 TBR=kalman@chromium.org,isherman@chromium.org,rockot@chromium.org NOTREECHECKS=true NOTRY=true BUG=398671 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -523 lines) Patch
M chrome/browser/chromeos/extensions/external_cache.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 6 chunks +32 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/updater/chrome_extension_downloader_factory.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/extensions/updater/chrome_extension_downloader_factory.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.h View 4 chunks +1 line, -34 lines 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 5 chunks +7 lines, -22 lines 0 comments Download
M chrome/browser/extensions/updater/extension_downloader_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 21 chunks +48 lines, -64 lines 0 comments Download
A chrome/browser/extensions/updater/manifest_fetch_data.h View 1 chunk +104 lines, -0 lines 0 comments Download
A chrome/browser/extensions/updater/manifest_fetch_data.cc View 1 chunk +166 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/safe_manifest_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_accessor.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D extensions/browser/updater/manifest_fetch_data.h View 1 chunk +0 lines, -128 lines 0 comments Download
D extensions/browser/updater/manifest_fetch_data.cc View 1 chunk +0 lines, -165 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nikita (slow)
Created Revert of Factor Chrome details out of update manifest fetching.
6 years, 4 months ago (2014-08-15 08:33:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/476073002/1
6 years, 4 months ago (2014-08-15 08:34:58 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 08:37:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (1) as 289821

Powered by Google App Engine
This is Rietveld 408576698