Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 476053002: [SyncFS] Add an injection point to DriveService creation at SyncEngine::Initialize (Closed)

Created:
6 years, 4 months ago by tzik
Modified:
6 years, 4 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Add an injection point to DriveService creation at SyncEngine::Initialize Add an injection point for testing. BUG=402356 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -15 lines) Patch
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.h View 4 chunks +19 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 6 chunks +26 lines, -12 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tzik
PTL
6 years, 4 months ago (2014-08-15 05:16:07 UTC) #1
peria
code LGTM. Please fill BUG line before submitting.
6 years, 4 months ago (2014-08-15 05:23:15 UTC) #2
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 4 months ago (2014-08-15 06:43:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/476053002/1
6 years, 4 months ago (2014-08-15 06:45:20 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 16:41:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 289918

Powered by Google App Engine
This is Rietveld 408576698