Rename inline sign in URL to chrome-signin

Rename inline sign in URL to chrome-signin

BUG=311019
R=atwilson@chromium.org, rogerta@chromium.org, xiyuan@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233316

[guohui, 2013-10-28 14:59:19]

Hey,

could you please take a look at the CL?

Thanks,

Hui

[xiyuan, 2013-10-28 16:54:26]

lgtm

https://codereview.chromium.org/47603008/diff/1/chrome/common/url_constants.cc
File chrome/common/url_constants.cc (right):

https://codereview.chromium.org/47603008/diff/1/chrome/common/url_constants.c...
chrome/common/url_constants.cc:56: const char kChromeUIInlineLoginURL[] =
"chrome://chrome-signin/";
nit: kChromeUIInlineLoginURL -> kChromeUIChromeSigninURL

https://codereview.chromium.org/47603008/diff/1/chrome/common/url_constants.c...
chrome/common/url_constants.cc:180: const char kChromeUIInlineLoginHost[] =
"chrome-signin";
nit: kChromeUIInlineLoginHost -> kChromeUIChromeSigninHost

[guohui, 2013-10-29 17:09:26]

https://codereview.chromium.org/47603008/diff/1/chrome/common/url_constants.cc
File chrome/common/url_constants.cc (right):

https://codereview.chromium.org/47603008/diff/1/chrome/common/url_constants.c...
chrome/common/url_constants.cc:56: const char kChromeUIInlineLoginURL[] =
"chrome://chrome-signin/";
On 2013/10/28 16:54:27, xiyuan wrote:
> nit: kChromeUIInlineLoginURL -> kChromeUIChromeSigninURL

Done.

https://codereview.chromium.org/47603008/diff/1/chrome/common/url_constants.c...
chrome/common/url_constants.cc:180: const char kChromeUIInlineLoginHost[] =
"chrome-signin";
On 2013/10/28 16:54:27, xiyuan wrote:
> nit: kChromeUIInlineLoginHost -> kChromeUIChromeSigninHost

Done.

[commit-bot: I haz the power, 2013-10-29 17:11:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/47603008/50001

[commit-bot: I haz the power, 2013-10-29 17:11:26]

Failed to apply patch for chrome/browser/ui/sync/inline_login_dialog.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/sync/inline_login_dialog.cc
  Hunk #1 FAILED at 28.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/sync/inline_login_dialog.cc.rej

Patch:       chrome/browser/ui/sync/inline_login_dialog.cc
Index: chrome/browser/ui/sync/inline_login_dialog.cc
diff --git a/chrome/browser/ui/sync/inline_login_dialog.cc
b/chrome/browser/ui/sync/inline_login_dialog.cc
index
73c9eebc1602bf01a6457a32c549b1af1b9504dd..533c941854bb1d0b0aee77528219deb234367c37
100644
--- a/chrome/browser/ui/sync/inline_login_dialog.cc
+++ b/chrome/browser/ui/sync/inline_login_dialog.cc
@@ -28,7 +28,7 @@ string16 InlineLoginDialog::GetDialogTitle() const {
 }
 
 GURL InlineLoginDialog::GetDialogContentURL() const {
-  return GURL(chrome::kChromeUIInlineLoginURL);
+  return GURL(chrome::kChromeUIChromeSigninURL);
 }
 
 void InlineLoginDialog::GetWebUIMessageHandlers(

[commit-bot: I haz the power, 2013-11-01 14:10:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/47603008/150001

[commit-bot: I haz the power, 2013-11-01 14:11:01]

Failed to apply patch for chrome/browser/ui/sync/inline_login_dialog.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/sync/inline_login_dialog.cc
  Hunk #1 FAILED at 28.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/sync/inline_login_dialog.cc.rej

Patch:       chrome/browser/ui/sync/inline_login_dialog.cc
Index: chrome/browser/ui/sync/inline_login_dialog.cc
diff --git a/chrome/browser/ui/sync/inline_login_dialog.cc
b/chrome/browser/ui/sync/inline_login_dialog.cc
index
73c9eebc1602bf01a6457a32c549b1af1b9504dd..533c941854bb1d0b0aee77528219deb234367c37
100644
--- a/chrome/browser/ui/sync/inline_login_dialog.cc
+++ b/chrome/browser/ui/sync/inline_login_dialog.cc
@@ -28,7 +28,7 @@ string16 InlineLoginDialog::GetDialogTitle() const {
 }
 
 GURL InlineLoginDialog::GetDialogContentURL() const {
-  return GURL(chrome::kChromeUIInlineLoginURL);
+  return GURL(chrome::kChromeUIChromeSigninURL);
 }
 
 void InlineLoginDialog::GetWebUIMessageHandlers(

[commit-bot: I haz the power, 2013-11-01 19:46:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/47603008/1

[commit-bot: I haz the power, 2013-11-01 20:39:03]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-11-04 16:11:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/47603008/1

[guohui, 2013-11-04 16:25:58]

+atwilson for owner review

chrome\browser\signin\signin_promo.cc
chrome\browser\ui\sync\inline_login_dialog.cc
chrome\browser\ui\sync\inline_login_dialog.h

[Roger Tawa OOO till Jul 10th, 2013-11-04 19:26:13]

lgtm

[commit-bot: I haz the power, 2013-11-04 20:12:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/47603008/330001

[commit-bot: I haz the power, 2013-11-04 20:12:12]

Failed to apply patch for chrome/browser/ui/sync/inline_login_dialog.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/sync/inline_login_dialog.cc
  Hunk #1 FAILED at 28.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/sync/inline_login_dialog.cc.rej

Patch:       chrome/browser/ui/sync/inline_login_dialog.cc
Index: chrome/browser/ui/sync/inline_login_dialog.cc
diff --git a/chrome/browser/ui/sync/inline_login_dialog.cc
b/chrome/browser/ui/sync/inline_login_dialog.cc
index
73c9eebc1602bf01a6457a32c549b1af1b9504dd..533c941854bb1d0b0aee77528219deb234367c37
100644
--- a/chrome/browser/ui/sync/inline_login_dialog.cc
+++ b/chrome/browser/ui/sync/inline_login_dialog.cc
@@ -28,7 +28,7 @@ string16 InlineLoginDialog::GetDialogTitle() const {
 }
 
 GURL InlineLoginDialog::GetDialogContentURL() const {
-  return GURL(chrome::kChromeUIInlineLoginURL);
+  return GURL(chrome::kChromeUIChromeSigninURL);
 }
 
 void InlineLoginDialog::GetWebUIMessageHandlers(

[Andrew T Wilson (Slow), 2013-11-05 14:54:52]

lgtm

[commit-bot: I haz the power, 2013-11-05 21:22:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/47603008/440001

[commit-bot: I haz the power, 2013-11-05 21:23:02]

Failed to apply patch for chrome/browser/ui/sync/inline_login_dialog.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/sync/inline_login_dialog.cc
  Hunk #1 FAILED at 28.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/sync/inline_login_dialog.cc.rej

Patch:       chrome/browser/ui/sync/inline_login_dialog.cc
Index: chrome/browser/ui/sync/inline_login_dialog.cc
diff --git a/chrome/browser/ui/sync/inline_login_dialog.cc
b/chrome/browser/ui/sync/inline_login_dialog.cc
index
73c9eebc1602bf01a6457a32c549b1af1b9504dd..533c941854bb1d0b0aee77528219deb234367c37
100644
--- a/chrome/browser/ui/sync/inline_login_dialog.cc
+++ b/chrome/browser/ui/sync/inline_login_dialog.cc
@@ -28,7 +28,7 @@ string16 InlineLoginDialog::GetDialogTitle() const {
 }
 
 GURL InlineLoginDialog::GetDialogContentURL() const {
-  return GURL(chrome::kChromeUIInlineLoginURL);
+  return GURL(chrome::kChromeUIChromeSigninURL);
 }
 
 void InlineLoginDialog::GetWebUIMessageHandlers(

[commit-bot: I haz the power, 2013-11-05 21:48:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/47603008/560001

[commit-bot: I haz the power, 2013-11-05 21:48:34]

Failed to apply patch for chrome/browser/ui/sync/inline_login_dialog.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/sync/inline_login_dialog.cc
  Hunk #1 FAILED at 28.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/sync/inline_login_dialog.cc.rej

Patch:       chrome/browser/ui/sync/inline_login_dialog.cc
Index: chrome/browser/ui/sync/inline_login_dialog.cc
diff --git a/chrome/browser/ui/sync/inline_login_dialog.cc
b/chrome/browser/ui/sync/inline_login_dialog.cc
index
73c9eebc1602bf01a6457a32c549b1af1b9504dd..533c941854bb1d0b0aee77528219deb234367c37
100644
--- a/chrome/browser/ui/sync/inline_login_dialog.cc
+++ b/chrome/browser/ui/sync/inline_login_dialog.cc
@@ -28,7 +28,7 @@ string16 InlineLoginDialog::GetDialogTitle() const {
 }
 
 GURL InlineLoginDialog::GetDialogContentURL() const {
-  return GURL(chrome::kChromeUIInlineLoginURL);
+  return GURL(chrome::kChromeUIChromeSigninURL);
 }
 
 void InlineLoginDialog::GetWebUIMessageHandlers(

[commit-bot: I haz the power, 2013-11-05 23:14:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/47603008/650001

[commit-bot: I haz the power, 2013-11-06 03:41:46]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-06 13:40:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/47603008/650001

[commit-bot: I haz the power, 2013-11-06 17:34:28]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[guohui, 2013-11-06 19:10:51]

Committed patchset #4 manually as r233316 (presubmit successful).