Issue 47603003: Use monotonic finish time for sync request completion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 47603003: Use monotonic finish time for sync request completion. (Closed)

Created:
7 years, 1 month ago by eustas

Modified:
7 years, 1 month ago

Reviewers:
Nate Chapin

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use monotonic finish time for sync request completion. Currently wall time is used. That is wrong. Since request is performed synchronously, current time fits well as finish time. BUG=309570 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160817

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	Source/core/fetch/ResourceLoader.cpp	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nate Chapin

Oops, I think I was using monotonicallyIncreasingTime() when I first wrote that, then discovered responseTime() ...

7 years, 1 month ago (2013-10-28 17:09:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/47603003/1

7 years, 1 month ago (2013-10-29 06:09:57 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=14445

7 years, 1 month ago (2013-10-29 07:23:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/47603003/1

7 years, 1 month ago (2013-10-29 08:55:59 UTC) #5

Message was sent while issue was closed.

Change committed as 160817

Expand Messages | Collapse Messages