Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 476023002: Land Recent QUIC Changes. (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)
Modified:
6 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0814_2
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. Slight improvement to QUIC version negotation debug logging. Merge internal change: 73319950 https://codereview.chromium.org/477813003/ Improve QUIC's SentEntropyManagerTest and removing a test from QuicConnectionTest that tests no code in QuicConnection. Merge internal change: 73298415 https://codereview.chromium.org/479463002/ quic_session.h doesn't need to include util/gtl/linked_hash_map.h. Merge internal change: 73256287 https://codereview.chromium.org/477863003/ Fix comment for QUIC handshake message tag COPT. Merge internal change: 73256108 https://codereview.chromium.org/474133002/ Not used in production. Add InRecovery() method to QUIC send algorithm interface, and pass slow start bool to bandwidth recorder. We still want to generate bandwidth estimates while in slow start, and include this information in the STK proto. We also need to know when we are in recovery mode so we can avoid calculating estimates. Merge internal change: 73239536 https://codereview.chromium.org/479443002/ Add a flag to enable QUIC's BBR congestion control by default instead of Cubic in order to test and gather logs on internal servers. Merge internal change: 73146298 https://codereview.chromium.org/477863002/ Add a QuicSustainedBandwidthEstimator class. Not yet used. Followup change list in progress (not ready for review, but in case you want to see intended usage) which does the following: 1) Use this in the QuicSentPacketManager. 2) Detect substantial differences between subsequent sustained bandwidth estimates. 3) Send estimates to client in server config update. internal change list: 72831442 Merge internal change: 73132177 https://codereview.chromium.org/477053002/ Re-add the QUIC DCHECK to ensure packets are always sent in the order of increasing sequence number. Merge internal change: 73128051 https://codereview.chromium.org/469383004/ Change to optimize QUIC's RetransmittableFrames::HasCryptoHandshake by storing it once when the crypto frame is added to RetransmittableFrames. Merge internal change: 73125935 https://codereview.chromium.org/467263003/ Add an Update method on QuicAlarm which contains a granularity. Also change the idle network timeout to be 1 second shorter on the client and 1 second longer on the server. Change saves ~2% of CPU according to an EndToEndTest profile. Merge internal change: 73125905 https://codereview.chromium.org/471313002/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -109 lines) Patch
M net/base/linked_hash_map.h View 1 chunk +22 lines, -0 lines 0 comments Download
M net/net.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 2 chunks +1 line, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_alarm.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_alarm.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M net/quic/quic_alarm_test.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 11 chunks +28 lines, -20 lines 0 comments Download
M net/quic/quic_connection_helper_test.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 4 chunks +7 lines, -40 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 1 chunk +5 lines, -14 lines 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +4 lines, -1 line 0 comments Download
M net/quic/quic_protocol.cc View 3 chunks +5 lines, -11 lines 0 comments Download
M net/quic/quic_sent_entropy_manager.h View 2 chunks +6 lines, -0 lines 0 comments Download
M net/quic/quic_sent_entropy_manager.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M net/quic/quic_sent_entropy_manager_test.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A net/quic/quic_sustained_bandwidth_recorder.h View 1 chunk +86 lines, -0 lines 0 comments Download
A net/quic/quic_sustained_bandwidth_recorder.cc View 1 chunk +62 lines, -0 lines 0 comments Download
A net/quic/quic_sustained_bandwidth_recorder_test.cc View 1 chunk +125 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +3 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper_test.cc View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ramant (doing other things)
6 years, 4 months ago (2014-08-15 03:31:17 UTC) #1
Ryan Hamilton
lgtm
6 years, 4 months ago (2014-08-15 14:38:13 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 4 months ago (2014-08-15 22:04:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/476023002/1
6 years, 4 months ago (2014-08-15 22:05:50 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 06:11:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 290106

Powered by Google App Engine
This is Rietveld 408576698