Issue 476013002: Mark two inner classes in net/ exported

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 476013002: Mark two inner classes in net/ exported (Closed)

Created:
6 years, 4 months ago by hans

Modified:
6 years, 4 months ago

Reviewers:
Nico, willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mark two inner classes in net/ exported The inner class needs to be exported in case any uses in inline methods or vtable of the outer class causes it to potentially be referenced across a shared library boundary. On non-Windows, the visibility attribute is already inherited by nested classes, but on Windows, they must be marked explicitly. BUG=82385 R=thakis@chromium.org, willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289977

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	net/cert/multi_threaded_cert_verifier.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	net/websockets/websocket_inflater.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

The CQ bit was checked by willchan@chromium.org

6 years, 4 months ago (2014-08-15 16:33:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/476013002/1

6 years, 4 months ago (2014-08-15 16:35:02 UTC) #5

hans

6 years, 4 months ago (2014-08-15 19:29:50 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as 289977 (presubmit successful).

Expand Messages | Collapse Messages