Issue 476003002: Mark AppCacheStorage::DelegateReference exported

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 476003002: Mark AppCacheStorage::DelegateReference exported (Closed)

Created:
6 years, 4 months ago by hans

Modified:
6 years, 4 months ago

Reviewers:
michaeln, Nico

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mark AppCacheStorage::DelegateReference exported The inner class needs to be exported in case any uses in inline methods or vtable of the outer class causes it to potentially be referenced across a shared library boundary. On non-Windows, the visibility attribute is already inherited by nested classes, but on Windows, they must be marked explicitly. BUG=82385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289896

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	content/browser/appcache/appcache_storage.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/476003002/1

6 years, 4 months ago (2014-08-15 04:01:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 289896

Expand Messages | Collapse Messages