Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 475883005: UI/strings tweaks for automatic-settings-reset-banner (Closed)

Created:
6 years, 4 months ago by gab
Modified:
6 years, 4 months ago
Reviewers:
Bernhard Bauer, egm
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

UI/strings tweaks for automatic-settings-reset-banner NOTRY=True BUG=397248 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290733

Patch Set 1 #

Patch Set 2 : Remove "browser" from all reset strings and dont break before Learn more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gab
[CC egm who's handling last minute UI decisions] Bernhard, we are working to get the ...
6 years, 4 months ago (2014-08-19 20:06:26 UTC) #1
Bernhard Bauer
lgtm
6 years, 4 months ago (2014-08-19 20:29:49 UTC) #2
gab
@egm, see latest update, please confirm that these are the intended strings.
6 years, 4 months ago (2014-08-20 02:02:20 UTC) #3
egm
On 2014/08/20 02:02:20, gab wrote: > @egm, see latest update, please confirm that these are ...
6 years, 4 months ago (2014-08-20 02:13:13 UTC) #4
gab
The CQ bit was checked by gab@chromium.org
6 years, 4 months ago (2014-08-20 02:13:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/475883005/20001
6 years, 4 months ago (2014-08-20 02:14:46 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 02:16:06 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 290733

Powered by Google App Engine
This is Rietveld 408576698