Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: extensions/browser/notification_types.h

Issue 475813004: Clean up NOTIFICATION_EXTENSION_PAGE_ACTION_[ COUNT | VISIBILITY ]_CHANGED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac Compile Fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/notification_types.h
diff --git a/extensions/browser/notification_types.h b/extensions/browser/notification_types.h
index 74ab91c6e6339a2b19161bf2e159605e6fc9873c..acc8e6e111a18e805e695d94fa8370f5b2604ccf 100644
--- a/extensions/browser/notification_types.h
+++ b/extensions/browser/notification_types.h
@@ -121,19 +121,14 @@ enum NotificationType {
// browser action belongs to.
NOTIFICATION_EXTENSION_BROWSER_ACTION_UPDATED,
- // Sent when the count of page actions has changed. Note that some of them
- // may not apply to the current page. The source is a LocationBar*. There
- // are no details.
- NOTIFICATION_EXTENSION_PAGE_ACTION_COUNT_CHANGED,
-
// Sent when a browser action's visibility has changed. The source is the
// ExtensionPrefs* that changed, and the details are a std::string with the
// extension's ID.
NOTIFICATION_EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED,
- // Sent when a page action's visibility has changed. The source is the
- // ExtensionAction* that changed. The details are a WebContents*.
- NOTIFICATION_EXTENSION_PAGE_ACTION_VISIBILITY_CHANGED,
+ // Sent when the page actions have been updated. The source is a WebContents*,
+ // and there are no details.
+ NOTIFICATION_EXTENSION_PAGE_ACTIONS_UPDATED,
// Sent when a system indicator action's state has changed. The source is the
// BrowserContext* that the browser action belongs to. The details are the

Powered by Google App Engine
This is Rietveld 408576698