chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm - Issue 475813004: Clean up NOTIFICATION_EXTENSION_PAGE_ACTION_[ COUNT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

Issue 475813004: Clean up NOTIFICATION_EXTENSION_PAGE_ACTION_[ COUNT | VISIBILITY ]_CHANGED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master for CQ Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm ('k') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm b/chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

index 3f6ac833c65c3c8b5aaca127915d32db4fb0ab87..7a887fa994740d8d28e3d648d73dcd3da6b21230 100644

--- a/chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

+++ b/chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

@@ -21,7 +21,8 @@

#import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"

#include "chrome/browser/ui/webui/extensions/extension_info_ui.h"

#include "components/sessions/session_id.h"

-#include "content/public/browser/notification_service.h"

+#include "content/public/browser/notification_details.h"

+#include "content/public/browser/notification_source.h"

#include "content/public/browser/web_contents.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/common/manifest_handlers/icons_handler.h"

@@ -152,13 +153,8 @@ void PageActionDecoration::UpdateVisibility(WebContents* contents,

}

- if (IsVisible() != visible) {

+ if (IsVisible() != visible)

SetVisible(visible);

- content::NotificationService::current()->Notify(

- extensions::NOTIFICATION_EXTENSION_PAGE_ACTION_VISIBILITY_CHANGED,

- content::Source<ExtensionAction>(page_action_),

- content::Details<WebContents>(contents));

- }

}

void PageActionDecoration::SetToolTip(NSString* tooltip) {