Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 475813003: [GCM] Fixing a bug with old registration ID not being removed (Closed)

Created:
6 years, 4 months ago by fgorski
Modified:
6 years, 4 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[GCM] Fixing a bug with old registration ID not being removed We are suffering from behavior where old registration ID is not really removed from gcm store when unregistered. BUG=384431 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M google_apis/gcm/engine/gcm_store_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fgorski
PTAL. This is the source of unregistered reg IDs.
6 years, 4 months ago (2014-08-14 23:41:33 UTC) #1
Nicolas Zea
lgtm
6 years, 4 months ago (2014-08-14 23:44:44 UTC) #2
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 4 months ago (2014-08-14 23:50:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/475813003/1
6 years, 4 months ago (2014-08-14 23:54:58 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 15:12:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 289860

Powered by Google App Engine
This is Rietveld 408576698