Source/devtools/front_end/sdk/TracingModel.js - Issue 475803002: Make profiling lock global rather than per Target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sdk/TracingModel.js

Issue 475803002: Make profiling lock global rather than per Target (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Extracted Lock.js Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/sdk/TracingModel.js

diff --git a/Source/devtools/front_end/sdk/TracingModel.js b/Source/devtools/front_end/sdk/TracingModel.js

index 283b5ba158a3955d1b4f74e99a2aaa18c11dfb34..98ffa8145d2ae7883a2e69c5d2103662d27791e9 100644

--- a/Source/devtools/front_end/sdk/TracingModel.js

+++ b/Source/devtools/front_end/sdk/TracingModel.js

@@ -101,7 +101,7 @@ WebInspector.TracingModel.prototype = {

start: function(categoryFilter, options, callback)

{

- this.target().profilingLock.acquire();

+ WebInspector.profilingLock.acquire();

this.reset();

var bufferUsageReportingIntervalMs = 500;

TracingAgent.start(categoryFilter, options, bufferUsageReportingIntervalMs, callback);

@@ -113,7 +113,7 @@ WebInspector.TracingModel.prototype = {

if (!this._active)

return;

TracingAgent.end(this._onStop.bind(this));

- this.target().profilingLock.release();

+ WebInspector.profilingLock.release();

/**