Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Unified Diff: Source/devtools/front_end/sdk/DebuggerModel.js

Issue 475803002: Make profiling lock global rather than per Target (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Extracted Lock.js Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/DebuggerModel.js
diff --git a/Source/devtools/front_end/sdk/DebuggerModel.js b/Source/devtools/front_end/sdk/DebuggerModel.js
index aed5655a3200f20fee3e50ea04f144c97de33a24..69a48a531fce3cad8c0641e50ac186f470caaafa 100644
--- a/Source/devtools/front_end/sdk/DebuggerModel.js
+++ b/Source/devtools/front_end/sdk/DebuggerModel.js
@@ -55,7 +55,7 @@ WebInspector.DebuggerModel = function(target)
WebInspector.settings.pauseOnCaughtException.addChangeListener(this._pauseOnExceptionStateChanged, this);
WebInspector.settings.enableAsyncStackTraces.addChangeListener(this._asyncStackTracesStateChanged, this);
- target.profilingLock.addEventListener(WebInspector.Lock.Events.StateChanged, this._profilingStateChanged, this);
+ WebInspector.profilingLock.addEventListener(WebInspector.Lock.Events.StateChanged, this._profilingStateChanged, this);
this.enableDebugger();
@@ -171,7 +171,7 @@ WebInspector.DebuggerModel.prototype = {
_profilingStateChanged: function()
{
if (WebInspector.experimentsSettings.disableAgentsWhenProfile.isEnabled()) {
- if (this.target().profilingLock.isAcquired())
+ if (WebInspector.profilingLock.isAcquired())
this.disableDebugger();
else
this.enableDebugger();
@@ -182,7 +182,7 @@ WebInspector.DebuggerModel.prototype = {
_asyncStackTracesStateChanged: function()
{
const maxAsyncStackChainDepth = 4;
- var enabled = WebInspector.settings.enableAsyncStackTraces.get() && !this.target().profilingLock.isAcquired();
+ var enabled = WebInspector.settings.enableAsyncStackTraces.get() && !WebInspector.profilingLock.isAcquired();
this._agent.setAsyncCallStackDepth(enabled ? maxAsyncStackChainDepth : 0);
},

Powered by Google App Engine
This is Rietveld 408576698