Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Unified Diff: Source/devtools/front_end/sdk/Target.js

Issue 475803002: Make profiling lock global rather than per Target (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/sdk/DebuggerModel.js ('k') | Source/devtools/front_end/sdk/TimelineManager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/Target.js
diff --git a/Source/devtools/front_end/sdk/Target.js b/Source/devtools/front_end/sdk/Target.js
index 1b781d8b96d2741d82400d76817216d0601dbd35..86a19b18a2e07cf5c6e123a1602129f0a2500326 100644
--- a/Source/devtools/front_end/sdk/Target.js
+++ b/Source/devtools/front_end/sdk/Target.js
@@ -32,9 +32,6 @@ WebInspector.Target = function(name, connection, callback)
this.workerAgent().canInspectWorkers(this._initializeCapability.bind(this, WebInspector.Target.Capabilities.CanInspectWorkers, this._loadedWithCapabilities.bind(this, callback)));
if (WebInspector.experimentsSettings.timelineOnTraceEvents.isEnabled())
this.consoleAgent().setTracingBasedTimeline(true);
-
- /** @type {!WebInspector.Lock} */
- this.profilingLock = new WebInspector.Lock();
}
/**
@@ -433,3 +430,6 @@ WebInspector.TargetManager.Observer.prototype = {
* @type {!WebInspector.TargetManager}
*/
WebInspector.targetManager = new WebInspector.TargetManager();
+
+/** @type {!WebInspector.Lock} */
+WebInspector.profilingLock = new WebInspector.Lock();
sergeyv 2014/08/14 15:43:10 In my opinion it is not appropriate place to decla
yurys 2014/08/14 15:54:10 Yeah, I was thinking about it too. Done.
« no previous file with comments | « Source/devtools/front_end/sdk/DebuggerModel.js ('k') | Source/devtools/front_end/sdk/TimelineManager.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698