content/browser/frame_host/navigation_request.h - Issue 475783002: PlzNavigate: add cancel navigation logic for uncommitted requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.h

Issue 475783002: PlzNavigate: add cancel navigation logic for uncommitted requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Nasko's comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_before_commit_info.cc ('k') | content/browser/frame_host/navigation_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_request.h

diff --git a/content/browser/frame_host/navigation_request.h b/content/browser/frame_host/navigation_request.h

index 6cc1cd2fe98b6bcaf4a44e74ae2e4f66ffeb3eca..b913019e60b623bfd667ae08736068dcfed344c6 100644

--- a/content/browser/frame_host/navigation_request.h

+++ b/content/browser/frame_host/navigation_request.h

@@ -32,7 +32,13 @@ class NavigationRequest {

// manipulated on the UI thread.

void BeginNavigation(scoped_refptr<ResourceRequestBody> body);

+ int64 navigation_request_id() const { return navigation_request_id_; }

private:

+ // The next available browser-global navigation request ID.

+ static int64 next_navigation_request_id_;

davidben 2014/08/25 17:31:34 Nit: This may as well be a global in navigation_re

carlosk 2014/08/27 15:31:59 Done.

+ const int64 navigation_request_id_;

const NavigationRequestInfo info_;

const int64 frame_node_id_;

« no previous file with comments | « content/browser/frame_host/navigation_before_commit_info.cc ('k') | content/browser/frame_host/navigation_request.cc » ('j') | no next file with comments »